-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory collection default for infra manager #15082
Conversation
end | ||
|
||
def clusters(extra_attributes = {}) | ||
attributes = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the parser you use uid_ems as manager ref, so in this case you should have here
:manager_ref => [:uid_ems]
def clusters(extra_attributes = {}) | ||
attributes = { | ||
:model_class => ::EmsCluster, | ||
:attributes_blacklist => [:ems_children] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing :association => :clusters
b5759d7
to
372c9a3
Compare
Checked commit pkliczewski@3498e00 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This PR provides not finished default manager but it enables ManageIQ/manageiq-providers-ovirt#35 to run so it would be great to have it in as is and improve as we implement full refresh. |
@matobet please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍
@agrare should be ready to merge, there are few TODOs, but it's best to do them incrementally. @pkliczewski is focusing on having targeted refresh of the Vm done first. |
Infra manager containing defaults for inventory collection. Needed for:
ManageIQ/manageiq-providers-ovirt#35